Skip to content

[release-4.20] OCPBUGS-78439: Backport OCPBUGS-61536: vsphere settings#16141

Open
celdrake wants to merge 2 commits intoopenshift:release-4.20from
celdrake:OCPBUGS-61536-vsphere-settings-4.20
Open

[release-4.20] OCPBUGS-78439: Backport OCPBUGS-61536: vsphere settings#16141
celdrake wants to merge 2 commits intoopenshift:release-4.20from
celdrake:OCPBUGS-61536-vsphere-settings-4.20

Conversation

@celdrake
Copy link
Contributor

Backport of OCPBUGS-61536 for OpenShift 4.20

Includes:

343b6dd (prevents conflicts afterwards)
1634f1c

celdrake and others added 2 commits March 13, 2026 09:16
* Improve error message in vsphere-plugin to identify wrong configMap contents

* Remove dot to avoid duplicating labels
…e-settings

OCPBUGS-61536: Fix incorrect handling of vSphere settings
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 13, 2026
@openshift-ci-robot
Copy link
Contributor

@celdrake: This pull request references Jira Issue OCPBUGS-61536, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.21.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead
  • expected Jira Issue OCPBUGS-61536 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Backport of OCPBUGS-61536 for OpenShift 4.20

Includes:

343b6dd (prevents conflicts afterwards)
1634f1c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from mareklibra and rawagner March 13, 2026 08:20
@celdrake
Copy link
Contributor Author

/jira cherrypick OCPBUGS-61536

@openshift-ci-robot
Copy link
Contributor

@celdrake: Jira Issue OCPBUGS-61536 has been cloned as Jira Issue OCPBUGS-78439. Will retitle bug to link to clone.
/retitle OCPBUGS-78439: Backport OCPBUGS-61536: vsphere settings

Details

In response to this:

/jira cherrypick OCPBUGS-61536

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title Backport OCPBUGS-61536: vsphere settings OCPBUGS-78439: Backport OCPBUGS-61536: vsphere settings Mar 13, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 69ab5ca5-5d35-4513-a229-40621a785bf2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 13, 2026
@openshift-ci-robot
Copy link
Contributor

@celdrake: This pull request references Jira Issue OCPBUGS-78439, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-61536 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-61536 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0, 4.21.z
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Backport of OCPBUGS-61536 for OpenShift 4.20

Includes:

343b6dd (prevents conflicts afterwards)
1634f1c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei March 13, 2026 08:21
@celdrake celdrake changed the title OCPBUGS-78439: Backport OCPBUGS-61536: vsphere settings [release-4.20] OCPBUGS-78439: Backport OCPBUGS-61536: vsphere settings Mar 13, 2026
@celdrake
Copy link
Contributor Author

/retest

2 similar comments
@celdrake
Copy link
Contributor Author

/retest

@celdrake
Copy link
Contributor Author

/retest

@jhadvig
Copy link
Member

jhadvig commented Mar 19, 2026

/approvce
/label backport-risk-assessed
/lgtm
/retest

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 19, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celdrake, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 19, 2026

@celdrake: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console e689a04 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants